LaserWeb4 icon indicating copy to clipboard operation
LaserWeb4 copied to clipboard

lw.rasterizer improvements

Open tbfleming opened this issue 7 years ago • 20 comments

Running list of desired rasterizer improvements as we remember them.

  • High priority: Option to vary feed with pixel value. Users aren't getting anywhere near the image quality they used to get when this was present.
  • Consider dropping the image manipulation options (contrast, etc.). We might just drop it in the UI. Both new users and expert users ignore them; expert users use external apps to prep images. Unknown: do intermediate users use these options?
  • Support new settings for LinuxCNC, Mach, and Marlin users (#334).
  • Long term: consider adding post processing support. I started experimenting with an interface for this on the new lathe stuff. If it ends up working well I may spread it to the rest of the path CAM. The start of the interface lives at https://github.com/LaserWeb/LaserWeb4/blob/e53c11bc0cfb6d3be940045aeb00a65d57c81d58/src/lib/cam-gcode-lathe.js#L18

tbfleming avatar Aug 21 '17 14:08 tbfleming

"High priority: Option to vary feed with pixel value."! Yay! Best news ever! #BRINGITBACK!

ghost avatar Aug 21 '17 15:08 ghost

Marking it high priority doesn't mean we have any volunteers to do it :(

tbfleming avatar Aug 21 '17 16:08 tbfleming

The image filtering options became far more useful once the preview became available.

IMHO, the options in order of usefulness and should be considered leaving in are: #1 Invert Color (very useful) #2: Brightness/Contrast (covers most of the tweaking necessary before needing to jump into external photo editing software) #3 Smoothing (would be far more useful if amount could be dialled in) #4 Dithering (would be useful if this feature was expanded.)

ghost avatar Aug 25 '17 05:08 ghost

I added 2, or 3, lines to Marlin and I have been using LW4 for a few days. All I had to do was tell it smoothie and verbose output so the g commands are all on one line. btw, there is a bug in LW4 when I touch the gcode section it loses all LF/CR and there is no way to bring it back so I am stuck at one line. I don't do github so opening tickets etc... I have no idea and this may already be a known issue.

DarkAlchy avatar Oct 06 '17 00:10 DarkAlchy

when I touch the gcode section it loses all LF/CR

What do you mean?

tbfleming avatar Oct 06 '17 00:10 tbfleming

Well, if I add more than one line or if I even touch the gcode already there it will force that gcode section on one line so I will give you an example. Settings->Gcode->Gcode Start-> G21 ; Set units to mm G90 ; Absolute positioning

If I add to that or modify that (say I erase the g and put it back) in the actual gcode written it loses the LF/CR so becomes G21 ; Set units to mmG90 ; Absolute positioning

If I go to any section in there to add my own code if I do more than one line it does the same as I just showed. I thought I had to add \n but that didn't do anything but add it between the last letter of the line and the first letter of the next line but all on one line. The only way to fix it once that happens is to delete the machine and start over.

DarkAlchy avatar Oct 06 '17 08:10 DarkAlchy

Could be it only loses CR? Could you check with an editor that supports LN format? Scite, vscode, etc..

El 6 oct. 2017 10:47 a. m., "DarkAlchy" [email protected] escribió:

Well, if I add more than one line or if I even touch the gcode already there it will force that gcode section on one line so I will give you an example. Settings->Gcode->Gcode Start-> G21 ; Set units to mm G90 ; Absolute positioning

If I add to that or modify that (say I erase the g and put it back) in the actual gcode written it loses the LF/CR so becomes G21 ; Set units to mmG90 ; Absolute positioning

If I go to any section in there to add my own code if I do more than one line it does the same as I just showed. I thought I had to add \n but that didn't do anything but at it between the last letter of the line and the first letter of the next line but all on one line. The only way to fix it once that happens is to delete the machine and start over.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/398#issuecomment-334696225, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoIYA0x70_5immMfMtVw-4vT23xM5G6ks5spekLgaJpZM4O9bCS .

jorgerobles avatar Oct 06 '17 08:10 jorgerobles

I will go one better and use a hex editor on it and see what it is and what it becomes.

DarkAlchy avatar Oct 06 '17 08:10 DarkAlchy

0x0d,0x0a becomes 0x0A so the CR is lost.

DarkAlchy avatar Oct 06 '17 08:10 DarkAlchy

Then should not be a problem running the gcode. CR is a win only visualization issue.

El 6 oct. 2017 10:57 a. m., "DarkAlchy" [email protected] escribió:

0x0d,0x0a becomes 0x0A so the CR is lost.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/398#issuecomment-334698707, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoIYPkAEhzzNkgCAP96npa7F1YJbP5iks5speuOgaJpZM4O9bCS .

jorgerobles avatar Oct 06 '17 08:10 jorgerobles

Well, easy enough for it to be fixed and I am unsure if Marlin will still work like that or not. Maybe but it still sucks to see it all on one line be it just a visual bug or not. I hope it gets fixed since it should be dead easy to take care of it. I can't open Marlin right now to see if it wants 0a or 0d or 0d0a and since Marlin support is in the works best to nail it down.

DarkAlchy avatar Oct 06 '17 09:10 DarkAlchy

Yes, marlin works.. mine at least. got a couple hundred gcode files on my 3d printer that way.

El 6 oct. 2017 11:02 a. m., "DarkAlchy" [email protected] escribió:

Well, easy enough for it to be fixed and I am unsure if Marlin will still work like that or not. Maybe but it still sucks to see it all on one line be it just a visual bug or not. I hope it gets fixed since it should be dead easy to take care of it. I can't open Marlin to see if it wants 0a or 0d or 0d0a and since Marlin support is in the works best to nail it down.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/398#issuecomment-334699661, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoIYCJPfbhdhwPOkKetOIl6JQ3mqxGhks5speyHgaJpZM4O9bCS .

jorgerobles avatar Oct 06 '17 09:10 jorgerobles

You mean the Marlin code for LW4 has been implemented now?

DarkAlchy avatar Oct 06 '17 09:10 DarkAlchy

No, I mean marlin firmware understand LN only files :)

El 6 oct. 2017 11:17 a. m., "DarkAlchy" [email protected] escribió:

You mean the Marlin code for LW4 has been implemented now?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/398#issuecomment-334703019, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoIYOTmNrS8U8eF8Hw67TtPAqI5FWcOks5spfASgaJpZM4O9bCS .

jorgerobles avatar Oct 06 '17 09:10 jorgerobles

Ahhh, I figured but wasn't sure. As I said I hope this visual bug gets fixed but I wonder why modifying the boxes eats the CR?

DarkAlchy avatar Oct 06 '17 09:10 DarkAlchy

not sure why. All the devs use Linux/Mac machines, so could have been overlooked.

2017-10-06 11:24 GMT+02:00 DarkAlchy [email protected]:

Ahhh, I figured but wasn't sure. As I said I hope this visual bug gets fixed but I wonder why modifying the boxes eats the CR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/398#issuecomment-334704634, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoIYMX_tee73QANLbLR0_xl9pRSLiuVks5spfG5gaJpZM4O9bCS .

jorgerobles avatar Oct 06 '17 09:10 jorgerobles

Yep, as I figured. Well, hopefully someone reports it and puts in a ticket for the issue.

DarkAlchy avatar Oct 06 '17 09:10 DarkAlchy

@DarkAlchy The lw.comm-server only supports MarlinKimbra yet, because MK supports S values in G moves. Without that (old Marlin), the axes moves would stop at each S change, which makes it unusabe for raster engraving.

By the way: The multiline gcode settings fields work like expected on my Win10 machine.

cprezzi avatar Oct 06 '17 10:10 cprezzi

@DarkAlchy Are you using Notepad to view the gcode? Almost every other editor for Windows doesn't care about CR. I use this from Microsoft: https://code.visualstudio.com/ .

tbfleming avatar Oct 06 '17 12:10 tbfleming

@cprezzi I added the S command to vanilla Marlin so it works as I didn't want to mess with any forks since it is a 3d printer machine mainly.

@tbfleming Yep, been using it for 5 years for files like this as wordpad I never liked and notepad++ is way overkill. Thanks for the link.

DarkAlchy avatar Oct 06 '17 17:10 DarkAlchy