LaserWeb4 icon indicating copy to clipboard operation
LaserWeb4 copied to clipboard

Moving stable version to Master.

Open jorgerobles opened this issue 8 years ago • 10 comments

Hey all @openhardwarecoza, @tbfleming, @lautr3k , @cprezzi

Should we push stabilized versions to master? I mean, many users are complaining some pushes done to dev-es6, that in fact is a dev-evelopment branch. I don't know if this could be a mess, but maybe we have to offer master branch for stable functionalities.

jorgerobles avatar Mar 05 '17 09:03 jorgerobles

This would definitely make things easier for us to distribute the latest working and stable version to users. Could this also help resolve the electron exe and app compilation problems we are having?

ghost avatar Mar 05 '17 09:03 ghost

I hope so, but this implies some extra work, and we need hands. We need people that installs the latest versions (so a bit of development background will be great ) on development on pre-master, and perform Q&A. That is not a trivial work, be aware.

jorgerobles avatar Mar 05 '17 10:03 jorgerobles

We are still stuck without being able to offer exe and app versions of the software to our users because of an electron compile problem. The only version we can offer curtrently is 4036 which doesn't include a lot of the bug fixes you have applied as well as the most recent Comms from Claudio. At the moment we have an amazing piece of software which is stuck on GIT. Once we get past this problem, we will be involved compiling and QA.

ghost avatar Mar 05 '17 10:03 ghost

I pushed some fixes for the cache issue (issue #15 on lw.comm-server)

On Mar 5, 2017 12:11 PM, "DarklyLabs" [email protected] wrote:

We are still stuck without being able to offer exe and app versions of the software to our users because of an electron compile problem. The only version we can offer curtrently is 4036 which doesn't include a lot of the bug fixes you have applied as well as the most recent Comms from Claudio. At the moment we have an amazing piece of software which is stuck on GIT.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb4/issues/190#issuecomment-284218151, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr27O6Bu4DUo5CjMbiwoKkR2VYB0KKks5rioprgaJpZM4MTXZy .

ghost avatar Mar 05 '17 11:03 ghost

@openhardwarecoza Great! Will check and report back first thing in the morning.

ghost avatar Mar 05 '17 11:03 ghost

@jorgerobles I dont think this repo needs a master as we never want users downloading/using this directly. The stable releases will be made available as precompiled Electron applications?

ghost avatar Mar 05 '17 12:03 ghost

We may want to tag "releases" in this repo eventually to make appveyor/travis trigger on new releases?

ghost avatar Mar 05 '17 12:03 ghost

I think it would make sence to have a master branch for releases olny, so dev-es6 don't have to care about braking anything and there is a stable version available at any time.

cprezzi avatar Mar 05 '17 13:03 cprezzi

I was thinking the same @cprezzi

jorgerobles avatar Mar 05 '17 13:03 jorgerobles

We need to lock down the following before release:

  • Update git submodules
  • Remove --remote from installdev
  • Replace the git+ entries in package.json with released NPM packages or git submodules (I'm leaning toward git submodules)

This will make it possible to rebuild and branch off the release version without submodule pushes breaking it.

tbfleming avatar Mar 05 '17 14:03 tbfleming