Lars Artmann

Results 88 comments of Lars Artmann

The problem is the internal representation in [`internal/permission/permission.go`](https://github.com/charmbracelet/crush/blob/main/internal/permission/permission.go#L28-L32): ```go type PermissionNotification struct { ToolCallID string `json:"tool_call_id"` Granted bool `json:"granted"` Denied bool `json:"denied"` } ``` The data model is problematic. I...

I created a Pull Request to fix your issue: https://github.com/charmbracelet/crush/pull/1385 If you want to speed up a possible merge, leave a 👍 on it.

We should keep this issue open until my changes actually get merged or was it already resolved in the latest version your using @Arv2565?

I am working on the Pull Request for it. It got quite big and I am current fixing some performance issues. Soon it will be a lot better.

I really like the idea of showing the last used models. @alewtschuk are you planning to add this to the PR?

Does the Favourites section show up, even if you have no Favourites?

I would say this PR is in a good state now. It's a small but helpful change. Waiting for feedback.

I will update the PR, thank you all for the great feedback!

FYI: I made a bunch of changes. It currently does not compile, but I am also not done yet.

Manual testing is still pending, but I think the big parts are now figured out.