Laravel-Challenge-Route-Model-Binding icon indicating copy to clipboard operation
Laravel-Challenge-Route-Model-Binding copied to clipboard

Challenge Solved with explanation in README

Open FaycalBorsali opened this issue 3 years ago • 1 comments

I solved the challenge (like most os us did) but I also added as much explanation in the README as I found "useful". I hope this would help people that didn't get it understand why the solutions work.

FaycalBorsali avatar Jul 25 '21 12:07 FaycalBorsali

@FaycalBorsali wow amazing! Thanks for the effort.

And I didn't even know you can do such an open-close effect in Github's readme. Cooool.

I would gladly merge the PR, but thinking it would be bad for others who may try to solve this challenge later in the future, they won't have the original task anymore.

So could you please change the PR so it would not contain the fixed code? Instead, a better way would be adding before/after code pieces (well, one line of before/after) inside of the "detail" hidden blocks, I think.

Something like:

// Before:
Route::get('transactions/{transaction}/export', ...)

// After:
Route::get('transactions/{transaction:uuid}/export', ...)

Thanks again!

PovilasKorop avatar Jul 26 '21 04:07 PovilasKorop