Laravel-Challenge-Route-Model-Binding icon indicating copy to clipboard operation
Laravel-Challenge-Route-Model-Binding copied to clipboard

Published 20 hours ago • verified publisher icon LaravelDaily

Fixed given 3 issues

Open VijaySankhat opened this issue 3 years ago • 5 comments

Here is my solution for given issues, please review it

VijaySankhat avatar Jul 25 '21 05:07 VijaySankhat

@VijaySankhat incorrect solution, please see other correct Pull Requests #1 #2 #3 #4

Also, not sure why you deleted .env.example file, it should stay in the repository

PovilasKorop avatar Jul 25 '21 06:07 PovilasKorop

@PovilasKorop Sorry I am restoring that file. thank you for your time.

VijaySankhat avatar Jul 25 '21 06:07 VijaySankhat

@PovilasKorop Made suggested changes.

VijaySankhat avatar Jul 25 '21 06:07 VijaySankhat

@VijaySankhat yes you restored .env.examples but you still haven't solved those three original tasks. Please see PRs by other people and compare your code to theirs.

PovilasKorop avatar Jul 25 '21 06:07 PovilasKorop

@PovilasKorop , Okay, let me check those PR.

VijaySankhat avatar Jul 25 '21 06:07 VijaySankhat