Laravel-Challenge-ManyToMany-Olympics icon indicating copy to clipboard operation
Laravel-Challenge-ManyToMany-Olympics copied to clipboard

Submission/completing challenge

Open babul28 opened this issue 3 years ago • 2 comments

changelog

  • Using livewire to handling submitting sports medals standing
  • Use action class to separate logic to store standings of the competition
  • Dynamic list of country choices that make medals not obtained by the same country in one sport

cons

  • Because the livewire component renders all the country selection lists every time there is a change, the response size becomes quite large at around 60kb every request

babul28 avatar Aug 20 '21 16:08 babul28

@babul28 quickly reviewed your code. At times it feels overcomplicated with that Action class and separate Pivot model so I would do it in a more simple way. I will shoot a video with my version of the solution, and you will compare it with yours.

PovilasKorop avatar Aug 22 '21 10:08 PovilasKorop

At first I thought that I would not be able to directly access the pivot data from the relation, so because it was already done, I left it like that. But I was able to gain new knowledge after seeing other pull requests.

Thank you for the advice.

babul28 avatar Aug 22 '21 11:08 babul28