Update on a Menu-item - CheckValidity fails

[Faber44]

trafficstars

Bug report

Form isn't submited on update with "page slug input" selected.

What I've already tried to fix it:

HTML validation fails because of the attribute: required on disabled inputs (aka internal link input & external link input). Moved the required attribute only where it belongs in crud>fields>page_or_llink.blade.php :

BEFORE :

{{-- internal link input --}}
 <input
    type="text"
    class="form-control"
    placeholder="{{ trans('backpack::crud.internal_link_placeholder', ['url', url(config('backpack.base.route_prefix').'/page')]) }}"
    for="{{ $field['configurationNames']['link'] }}"
required
    @if(isset($entry))
        @if ($entry->{$field['configurationNames']['type']} !== 'internal_link' && $entry->{$field['configurationNames']['type']} !== 'page_link')
            disabled="disabled"
        @endif
  
        @if ($entry->{$field['configurationNames']['type']} === 'internal_link' && $entry->{$field['configurationNames']['link']})
            value="{{ $entry->{$field['configurationNames']['link']} }}"
        @endif
    @else
        disabled="disabled"
    @endif
   >

AFTER :

<input
    type="text"
    class="form-control"
    placeholder="{{ trans('backpack::crud.internal_link_placeholder', ['url', url(config('backpack.base.route_prefix').'/page')]) }}"
    for="{{ $field['configurationNames']['link'] }}"
    @if(isset($entry))
        @if ($entry->{$field['configurationNames']['type']} !== 'internal_link' && $entry->{$field['configurationNames']['type']} !== 'page_link')
            disabled="disabled"
        @endif

        @if ($entry->{$field['configurationNames']['type']} === 'internal_link' && $entry->{$field['configurationNames']['link']})
            value="{{ $entry->{$field['configurationNames']['link']} }}"
required
        @endif
    @else
        disabled="disabled"
    @endif
    >

Backpack, Laravel, PHP, DB version:

Backpack 6 Laravel 10 Php 8.2 MariaDB 10.6.5

[welcome[bot]]

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

• Bug Reports, Feature Requests - Github Issues (here);
• Quick help (How do I do X) - Gitter Chatroom;
• Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

[jcastroa87]

Hello @pxpm we have a problem here.

When we added a "Page Link" type Menu item, we came back to just updating the link. there is a problem that prevented the update.

Please let me know if you need further information.

Cheers.

[danielwaghorn]

This continues to be an issue with the package, and is essentially narrowed down to the page_or_link field type based on our testing.

The typical resolution on our side for this on projects is to override the page_or_link.blade.php template by copying it to resources/views/vendor/backpack/crud/fields/page_or_link.blade.php and removing the required attribute from all instances of .form-control.

[pxpm]

Thanks for the report, and sorry for the time it took to come back here and fix this. 🙏

Let us know if you are still experiencing issues 👍

Cheers