MenuCRUD icon indicating copy to clipboard operation
MenuCRUD copied to clipboard

Update on a Menu-item - CheckValidity fails

Open Faber44 opened this issue 11 months ago • 2 comments

Bug report

Form isn't submited on update with "page slug input" selected.

What I've already tried to fix it:

HTML validation fails because of the attribute: required on disabled inputs (aka internal link input & external link input). Moved the required attribute only where it belongs in crud>fields>page_or_llink.blade.php :

BEFORE :

{{-- internal link input --}}
 <input
    type="text"
    class="form-control"
    placeholder="{{ trans('backpack::crud.internal_link_placeholder', ['url', url(config('backpack.base.route_prefix').'/page')]) }}"
    for="{{ $field['configurationNames']['link'] }}"
required
    @if(isset($entry))
        @if ($entry->{$field['configurationNames']['type']} !== 'internal_link' && $entry->{$field['configurationNames']['type']} !== 'page_link')
            disabled="disabled"
        @endif
  
        @if ($entry->{$field['configurationNames']['type']} === 'internal_link' && $entry->{$field['configurationNames']['link']})
            value="{{ $entry->{$field['configurationNames']['link']} }}"
        @endif
    @else
        disabled="disabled"
    @endif
   >

AFTER :

<input
    type="text"
    class="form-control"
    placeholder="{{ trans('backpack::crud.internal_link_placeholder', ['url', url(config('backpack.base.route_prefix').'/page')]) }}"
    for="{{ $field['configurationNames']['link'] }}"
    @if(isset($entry))
        @if ($entry->{$field['configurationNames']['type']} !== 'internal_link' && $entry->{$field['configurationNames']['type']} !== 'page_link')
            disabled="disabled"
        @endif

        @if ($entry->{$field['configurationNames']['type']} === 'internal_link' && $entry->{$field['configurationNames']['link']})
            value="{{ $entry->{$field['configurationNames']['link']} }}"
required
        @endif
    @else
        disabled="disabled"
    @endif
    >

Backpack, Laravel, PHP, DB version:

Backpack 6 Laravel 10 Php 8.2 MariaDB 10.6.5

Faber44 avatar Mar 13 '24 15:03 Faber44