CRUD
CRUD copied to clipboard
[Bug] Trait method 'setupFetchOperationDefaults' will not be applied because it collides with 'FetchOperation'
Bug report
What I did
Implemented FetchOperation from PRO Module into a controller and received the warning from the IDE: Trait method 'setupFetchOperationDefaults' will not be applied because it collides with 'FetchOperation'
What I expected to happen
Work out of the box.
What happened
Error Message from IDE (PHPStorm) Code does work, so it's more of an aesthetic issue.
What I've already tried to fix it
Fix is simple by renaming the function "setupFetchOperationDefaults" to "setupFetchDefaults", following the pattern of the other Operations.
Is it a bug in the latest version of Backpack?
yes
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
backpack/crud: 5.5.4 backpack/pro: 1.6.3
Hello there! Thanks for opening your first issue on this repo!
Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.
Backpack communication channels:
- Bug Reports, Feature Requests - Github Issues (here);
- Quick help (How do I do X) - Gitter Chatroom;
- Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the
backpack-for-laraveltag; - Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;
Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.
Thank you!
-- Justin Case The Backpack Robot
Hi @srd2010! Thank you for reporting this!
We are aware of this as it was done as a temporary workaround to avoid breaking changes. We will get to clean it up in one of our next upgrades.
I am going to keep it open until we get to do it.
Thanks again! Cheers.
Hey @srd2010
I am doing some cleanup on some old issues.
I am not able to reproduce your issue in the latest version. If the issue still persist for you please comment with some example code that I can follow to reproduce it consistently.
Like @maurohmartinez said the FetchOperation is poorly named, but shouldn't pose issues to use.
Thanks for the report 🙏