Field column type

[munjaldevelopment]

WHY

BEFORE - Few column were not exists.

??

AFTER - New column has been added based on field.

[welcome[bot]]

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

• if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
• even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
• not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
• we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

-- Justin Case The Backpack Robot

[tabacitu]

Let's make a proper evaluation here. Please list all field types and column types here, each with their correspondent. That way, we can see black on white if they have correspondents. And then we know what should be in this PR.

[pxpm]

Hello @munjaldevelopment

I am not sure if @tabacitu told you, but don't work in the enum column as that one will be added in https://github.com/Laravel-Backpack/CRUD/pull/4678

Cheers

[munjaldevelopment]

Yes Pedro. @tabacitu https://github.com/tabacitu told me about that & I have removed my code changes & pushed code in my branch.

Your's Truly, MUNJAL MAYANK

CIO Microprixs Solution Pvt. Ltd.

http://www.microprixs.com

Contact: +91 - 9462045321.

E-mail: @.*** , @., @.

On Thu, Sep 29, 2022 at 6:48 PM Pedro Martins @.***> wrote:

Hello @munjaldevelopment https://github.com/munjaldevelopment

I am not sure if @tabacitu https://github.com/tabacitu told you, but don't work in the enum column as that one will be added in #4678 https://github.com/Laravel-Backpack/CRUD/pull/4678

Cheers

— Reply to this email directly, view it on GitHub https://github.com/Laravel-Backpack/CRUD/pull/4675#issuecomment-1262269093, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRGM2DOMO753JU37VWT5QDWAWJLFANCNFSM6AAAAAAQQ6PO3Q . You are receiving this because you were mentioned.Message ID: @.***>

[tabacitu]

Hey @munjaldevelopment , thanks a lot 🙏 I see there are a few columns where the issues have not been resolved, can you please check my suggestions above for password, summernote, upload, url? Thank youuu 🙏

@pxpm you want to give this a go, too?

[tabacitu]

Awesome - code looks squeaky clean now! Will wait for PR to demo, so we can easily test in the browser 🎉

[jcastroa87]

Hi there @pxpm here is my review:

Checkbox: OK

Checklist: OK

Checklist dependency: OK

Color: OK

Email: OK

Hidden: OK

Month: OK

Password: OK

Range: OK

Select grouped: PENDING TO TEST

Summer note: ERROR - Here you can see, when i add this column type, column size is huge, and didnt allow me to see and use Action column.

Switch: OK

Time: ERROR - here i check format in form is 24H, but in column show as default 12H, so there is different about value display Time form:

Upload: OK

Upload multiple: OK

URL: OK

Week: OK

So there is 1 pending column, 2 errors and there is almost everything else working normal.

Let me know if i miss something about test.

Cheers.

[tabacitu]

We've decided it's better for @jorgetwgroup to take this feature to the finish line.

[jcastroa87]

Hi @tabacitu everything was done, check this PR's:

https://github.com/Laravel-Backpack/demo/pull/430

https://github.com/Laravel-Backpack/CRUD/pull/4910

Cheers.

[scrutinizer-notifier]

A new inspection was created.

[welcome[bot]]

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

• give your opinion on other Github Issues & PRs;
• chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
• answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!

[tabacitu]

MERGED! 🎉 Thanks guys! Let's not forget we'll need to add these to the docs - I've added an issue for that here - https://github.com/Laravel-Backpack/docs/issues/405