CRUD icon indicating copy to clipboard operation
CRUD copied to clipboard

[Bug] Repeatable inside InlineCreate with same name as other repeatable already on page

Open pxpm opened this issue 4 years ago • 2 comments

Bug report

What I did

Added an InlineCreate that has a repeatable field inside the modal with the same name of one repeatable in the parent form.

What I expected to happen

Repeatable in InlineCreate to show the repeatable fields of the connected entity.

What happened

InlineCreate repeatable gets the "container" from the parent repeatable (they have the same name).

What I've already tried to fix it

Nothing at all, just noticed, it's a very edgy case, but probably add something to the docs about it?

Is it a bug in the latest version of Backpack?

sure it is.

pxpm avatar Nov 21 '21 11:11 pxpm

Aaahhh! Nasty one 😅

Does it happen in v4.2 too?

tabacitu avatar Nov 22 '21 08:11 tabacitu

Ahh sorry @tabacitu I should have tagged it.

I only tested this in 4.2 while working on other stuff not related to this. I haven't tried this yet in 4.1.

pxpm avatar Nov 22 '21 10:11 pxpm

@pxpm , just talked to @jorgetwgroup who's already created a PR for this, but hasn't submitted it. Please don't work on this until you talk with him, or he submits the PR. Let's not have two people working on the same PR.

tabacitu avatar Nov 15 '22 16:11 tabacitu

Idk why i cant assign project to this issue, but i create PR https://github.com/Laravel-Backpack/PRO/pull/106 to provide an alternative to solve this.

Cheers

jcastroa87 avatar Nov 22 '22 15:11 jcastroa87

Thanks for the PR @jorgetwgroup

I will be closing this issue since I think the PR is enough to track/discuss anything related to it.

Cheers 🙏

pxpm avatar Nov 23 '22 11:11 pxpm