WebAuthn icon indicating copy to clipboard operation
WebAuthn copied to clipboard
verified publisher icon Laragear

[2.x] Update readme to use `WebAuthnLoginController` and `WebAuthnRegisterController`

Open wwwDESIGN-basti opened this issue 3 years ago • 3 comments

PHP & Platform

8.1.2 & Ubuntu

Database

No response

Laravel version

9

Have you done this?

  • [X] I have checked my logs and I'm sure is a bug in this package.
  • [X] I can reproduce this bug in isolation (vanilla Laravel install)
  • [X] I can suggest a workaround as a Pull Request

Expectation

Description

Hey Guys,

The README file talks about an AttestationController file. This is not created during installation.

  1. How do I create these?
  2. How does Laravel know to speak to this controller?

Reproduction

-

Stack trace & logs

No response

wwwDESIGN-basti avatar Dec 16 '22 13:12 wwwDESIGN-basti

You have to create yourself if you don't publish the included controllers. I added a clarification on the code blocks for these hypothetical controllers.

DarkGhostHunter avatar Jan 19 '23 14:01 DarkGhostHunter

Did this file get renamed? I don't see any trace of AttestationController in the code anymore except for the mention in the README

aaronpk avatar May 18 '24 17:05 aaronpk

@aaronpk You're right, the controllers were renamed. I'll have to fix the README.

DarkGhostHunter avatar May 22 '24 03:05 DarkGhostHunter

Fixed on 3.0

DarkGhostHunter avatar Jul 28 '24 03:07 DarkGhostHunter