langstream icon indicating copy to clipboard operation
langstream copied to clipboard

Refactor config properties to kebab case

Open nicoloboschi opened this issue 2 years ago • 3 comments

I’ve noticed different config naming styles: 90% is kebab case (my-property), the rest is pascal (myProperty) and one is with underscore (my_property). We should move them all to the kebab case and keep compatibility

nicoloboschi avatar Oct 02 '23 13:10 nicoloboschi

Some examples:

  • language-detector uses allowedLanguages
  • unwrap-key-value uses unwrapKey
  • text-splitter uses splitter_type, length_function and others
  • python-* uses className

nicoloboschi avatar Oct 02 '23 13:10 nicoloboschi

I agree that we should fix all of them as use the kebab case, that is more JSON/YAML friendly.

eolivelli avatar Oct 02 '23 13:10 eolivelli

💯

cbornet avatar Oct 03 '23 20:10 cbornet