server icon indicating copy to clipboard operation
server copied to clipboard

[core, sql] Fix HP Latent Calculations and Minstrel's Ring

Open 9001-Sols opened this issue 1 month ago • 2 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR fixes latent HP and MP calculations to use total HP/MP after gear and buffs, instead of total Base HP/MP. It also changes the Minstrel's Ring to match the Sorcerer's Ring, which activates when HP < 76%, JP wiki source: https://wiki.ffo.jp/html/7159.html

Steps to test these changes

  • Set HP on BRD to 75% with a bunch of HP up gear equipped
  • Verify Minstrel's Ring is cutting spellcasting time by 20%

Unable to test HP_OVER_TP_UNDER_100

  • I didn't see any items that used this latent effect, so I was unable to test it

9001-Sols avatar Nov 21 '25 23:11 9001-Sols

This is going to need a round of retail testing accounting for all types of HP based latents because I'm not convinced they all work the same way (evidenced by the fact these rings are documented in multiple different ways on each wiki).

sruon avatar Nov 24 '25 19:11 sruon

Keep this open for now

Xaver-DaRed avatar Nov 24 '25 23:11 Xaver-DaRed