🐛 Light Spirit does not cast Protect IV until level 68

[almuth150]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Summon Light Spirit as level 63 SMN while out of combat. Eventually it will cast Protect III. Repeat at level 67 for the same result, and 68 for Protect IV. The spell list gives it access to Protect IV at 63, and removes access to Protect III at the same level, yet this erroneous behaviour exists. https://github.com/LandSandBoat/server/blob/base/sql/mob_spell_lists.sql#L2304

Expected behavior

It should cast Protect IV starting at level 63.

[Skold177]

Hello, thanks for your bug report. The issue is you're checking the spell list for a enemy Light Spirit. Avatars are handled in a different area.

https://github.com/LandSandBoat/server/blob/9072a59fb828a381c939b678d2a7c1fb2e9c45a4/scripts/globals/pets/avatar.lua

As you can see, Light Spirit will not obtain Protect IV until level 68.

We can update the behavior if you have captures from retail.

[ZenDiime]

Light Spirit casting ProtectIV retail @ level 63 retail

https://youtu.be/OG1eq95X2P8