🐛 Oversight with min/max level in mob_spell_lists

[MowFord]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

I haven't validated it in a running server, but fairly confident it's an issue

The whm spell list has a gap in pro/shell. I believe this would block a mob with that spell list from using pro/shell if lvl 76-79

There's likely other scenarios where this happens

Expected behavior

[Skold177]

There are tons of issues like this, not just with WHM. The Default BLM list also has some instances where they would lose access to casting -ga spells completely. I think an audit of all the default spell lists is warranted.

[UmeboshiXI]

I'm not 100% versed on the actual retail behavior. Assuming default generic job lists for mobs, do we know if mobs stop using certain spells in favor of better ones of the same tier?

• Stonega is unlocked at level 15 BLM
• Stonega II is unlocked at level 40 BLM

Current spell list:

INSERT INTO `mob_spell_lists` VALUES ('Beastmen_BLM',2,189,15,22);  -- stonega (15~22)
INSERT INTO `mob_spell_lists` VALUES ('Beastmen_BLM',2,190,40,47);  -- stonega_ii (40~47)

There is the gap between 22 and 40.

Should it be:

INSERT INTO `mob_spell_lists` VALUES ('Beastmen_BLM',2,189,15,22);  -- stonega (15~39)
INSERT INTO `mob_spell_lists` VALUES ('Beastmen_BLM',2,190,40,47);  -- stonega_ii (40~47)

or is there a point where a mob will stop using 1st tier stonega in favor of better tier 1 ga spells?

Another question is if their spells ever have over lap with the next tier. Example: After unlocking Stonega II, would they ever at any point use Stonega 1?

[sruon]

There's no proof the concept of shared spell lists even exist and it should be nuked out of existence in favor of actual captured spell lists per mob.