C2S Packets Validation [0x104 - 0x110]
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [ ] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
- Convert C2S packets code to trailing returns
- Deprecates 0x111 packet entirely (old lockstyle)
- Port 9 packets over. Fishing, RoE, Bazaar.
Notes:
- Skipped 0x112 because it does not match XiPackets at all, I need to spend some time looking at captures.
- 0x110_GP_CLI_COMMAND_FISHING_2 (new fishing) is aliased to 0x066_GP_CLI_COMMAND_FISHING (old fishing) because they are the same structure and go through the same handlers. Not even sure we still need to support 0x066.
Steps to test these changes
Still testing.
✨ Hello and thanks for the PR! ✨
🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.
RE: The old fishing packet: I would deprecate it and leave a note/warning behind saying that it's the same structure but modern clients use the new packet.
Done testing.
Opted to make GP_CLI_COMMAND_FISHING aliased to GP_CLI_COMMAND_FISHING_2 instead of the other way around since that's the legitimate packet nowadays.
Added a little more detail stating GP_CLI_COMMAND_FISHING is likely deprecated but we don't know for sure since the client still has handlers for it.