LandSandBoat
[Mobs] Create flying wyrm mixin and clean flight logic
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
Creates a mixin for flying wyrms flight logic, so we dont have the same logic repeated and coded diferently across the codebase
Steps to test these changes
Fight flying lizards
Could this apply to Ouryu in Monarch Linn for The Savage as well?
It already does, I thought. The idea is for this to be applicable to all wyrms that fly. Which admitedly arent that many more than this ones.
This ouryu can be forced down with the mistmelt item, unlike the Ouryu in The Savage II
Could this apply to Ouryu in Monarch Linn for The Savage as well?
It already does, I thought. The idea is for this to be applicable to all wyrms that fly. Which admitedly arent that many more than this ones.
This ouryu can be forced down with the mistmelt item, unlike the Ouryu in The Savage II
Ah, maybe I am missing something but I only see changes in the PR to the Ouryu mob file for Ouryu Cometh and not to the Ouryu mob file for The Savage.
Actually, I do have two small comments. Would the logic changes mean that mobs like Tiamat could use Mighty Strikes while in the air? Also should we be calling handlePhaseVariables on roam ticks as well, since some damage can take place even before engage, like a first damage spell?
I added a check just now to disable 2-houring while in mid-air.
2-hours already disabled changing phase after all