server icon indicating copy to clipboard operation
server copied to clipboard

🐛 Zeni calc for remaining HP% appears to have a typo

Open almuth150 opened this issue 8 months ago • 0 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Take pictures of mobs with the soultrapper, at low and high HP % remaining

Expected behavior

https://github.com/LandSandBoat/server/blob/base/scripts/globals/znm.lua#L288 there appears to be a missing set of brackets here because there's currently a useless * 1 multiplier. I'm not sure what it's supposed to be, but as it is now, getting a mob to 1% HP yields only +16.5 zeni, rather than some kind of multiplier. Brackets around the added parts would yield *17.5 at 1% remaining.

almuth150 avatar May 17 '25 02:05 almuth150