server icon indicating copy to clipboard operation
server copied to clipboard

[sql] add content tags to 25 base game/ROZ synthesis recipes

Open Grahf0085 opened this issue 8 months ago • 4 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds content tags to 25 items added to the game before COP. I wasn't 100% on what to call the content tag. I know this content tag, no matter what it's called, what affect anything in the game. But anyone could use the content tag to delete recipes they don't want, they could add a a content setting for base/roz to main.lua to control the recipes being added to the game, and it will narrow down what recipes were added during other expansions.

The full list of base/roz recipes I'm tracking is at: https://cloud.atavismxi.com/s/wYnABz7RH6sdz3K

I made this list many years ago...... can't remember how exactly I made it.

Steps to test these changes

Run dbtool and check content tags of the items in the database.

Grahf0085 avatar May 02 '25 20:05 Grahf0085

Why set something to Base/ROZ? Wouldn't it be one or the other?

LacunaXI avatar May 07 '25 03:05 LacunaXI

Given that these are our settings for enabling/disabling content:

    -- Enable Expansion (1 = Enabled, 0 = Disabled)
    ENABLE_COP       = 1,
    ENABLE_TOAU      = 1,
    ENABLE_WOTG      = 1,
    ENABLE_ACP       = 1,
    ENABLE_AMK       = 1,
    ENABLE_ASA       = 1,
    ENABLE_ABYSSEA   = 1,
    ENABLE_SOA       = 1,
    ENABLE_ROV       = 1,
    ENABLE_TVR       = 1,
    ENABLE_VOIDWATCH = 1, -- Not an expansion, but has its own storyline. (Not Implemented)

What was the point in tagging these without adding the new setting? (which should probably just be called ENABLE_ROTZ, since we target the english client and BASE & ROTZ shipped together)

zach2good avatar May 07 '25 09:05 zach2good

Why set something to Base/ROZ? Wouldn't it be one or the other?

Which one do you want?

Grahf0085 avatar May 09 '25 03:05 Grahf0085

Why set something to Base/ROZ? Wouldn't it be one or the other?

Which one do you want?

Given that these are our settings for enabling/disabling content:

    -- Enable Expansion (1 = Enabled, 0 = Disabled)
    ENABLE_COP       = 1,
    ENABLE_TOAU      = 1,
    ENABLE_WOTG      = 1,
    ENABLE_ACP       = 1,
    ENABLE_AMK       = 1,
    ENABLE_ASA       = 1,
    ENABLE_ABYSSEA   = 1,
    ENABLE_SOA       = 1,
    ENABLE_ROV       = 1,
    ENABLE_TVR       = 1,
    ENABLE_VOIDWATCH = 1, -- Not an expansion, but has its own storyline. (Not Implemented)

What was the point in tagging these without adding the new setting? (which should probably just be called ENABLE_ROTZ, since we target the english client and BASE & ROTZ shipped together)

I think we're in a much better spot now. I just tried to make a workbench with RESTRICT_CONTENT = 1 and ENABLE_ROTZ = 0 and it didn't let me make a workbench. Then I set ENABLE_ROTZ = 1 and it let me make a workbench.

Grahf0085 avatar May 09 '25 03:05 Grahf0085

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 18 '25 02:09 github-actions[bot]