server icon indicating copy to clipboard operation
server copied to clipboard

🐛 Treasure Hunter proc system does not execute on WS

Open sruon opened this issue 10 months ago • 3 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • [X] I have read and understood the Contributing Guide and the Code of Conduct.
  • [X] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Spawn a mob, use any WS. Using breakpoints see that the proc system code does not execute on the WS.

https://github.com/LandSandBoat/server/blob/7a51893d9ed1625d7cc4381b6522d93da86b525a/src/map/utils/battleutils.cpp#L1133

Expected behavior

Treasure Hunter can proc on the first hit of weaponskills, but will not display any message when it does. https://www.bg-wiki.com/ffxi/Treasure_Hunter

If it is activated during WS , no effect or log is displayed, so there is no way to tell. https://wiki-ffo-jp.translate.goog/html/1678.html?_x_tr_sl=ja&_x_tr_tl=en&_x_tr_hl=en&_x_tr_pto=sc

Somewhat related: Are enspells supposed to proc on weaponskills? Have not found any information proving or disproving it.

sruon avatar Mar 16 '25 01:03 sruon

✨ Thanks for the report! ✨

This is a friendly automated reminder that the maintainers won't look at your report until you've properly completed all of the checkboxes in the pre-filled template.

github-actions[bot] avatar Mar 16 '25 01:03 github-actions[bot]

Mobs are correctly tagged on WS, it's the TH upgrade system (which I linked in the original body) that's not being triggered.

sruon avatar Apr 19 '25 06:04 sruon