🐛 Throwing darts is mistakenly using the singing animation

[almuth150]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Equip a Dart, or any other throwing ammo equip that has no model, then do a ranged attack

Expected behavior

The animation shouldn't be the one used for singing a BRD song with no instrument. I think the proper animation is different from the one used for throwing shuriken, but I'm not 100% certain.

[Omnione]

Can confirm, a few throwing weapons are missing model data, simple PR if anyone wants to take the time going through the item_equipment.sql and filling the MID's in, will need to confirm using retail captures for things like shurikens and grenades but I think it may only be a few items missing, darts can all be MID(model) 22 as they don't show in game and as far as I know there is only 1 MID for darts.

[UmeboshiXI]

Dart shows it already has model ID of 22 in the database. I think I might recall something similar happening to me before and it was related to style lock. Mind try going into ingame menu, disabling style lock, then try throwing again and see if it still does it?

[Omnione]

Tested with style lock, same thing happens if the throwing weapon being style locked has no MID in item_equipment.sql, Interestingly though the in game command /stylelock off does not seem to change to ammo MID back to what the player currently has equipped,

So in conclusion,

Adding the correct MID's to all the missing throwing equipment will stop the incorrect animation playing but it does not fix the issue, This needs further investigation into why the ammo slot is not resetting back to currently equipped ammo.

[ayechonk]

I am not able to replicate the /lockstyle off issue:

• equip aht_urhgan_dart (mid=0)
• /lockstyle on
• equip dart (mid=22)
• /lockstyle off
• /range
• Proper range animation will play

I've requested retails caps of throwing skill items (skill 27) in item_weapon that has a item_equipment.mid of 0.

[almuth150]

After looking through the various darts in the item_equipment table (or at least items that end in "dart"), it turns out that only the "Dart" has a mid set - everything else, including the one I use in-game all has their mid set to 0. Doing what you described does indeed give a throwing animation that is appropriate for throwing darts, so it seems that the model of all of the other darts needs to be captured?

[ayechonk]

I think so. The cap is almost completed.

[ayechonk]

Just 11 records left to be updated. once i get the rest i'll put in a PR

---EDIT--- 8 left. 2 are holiday items and 1 is not implemented (throwing coin was never implemented)