LandSandBoat
[Lua] Fix several Eastern Altepa Desert and Fei'yin NM issues
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
The PR fixes several Eastern Altepa Desert and Fei'yin NM issues:
- Add to Centurio XII-I bodyguard spawning behavior with conquest control, damage taken mods, Eagle-Eye Shot use, and correct HP (Siknoz captures here, here). Note that the bodyguards no longer spawn as normal mobs and only spawn with Centurio if the region is beastmen controlled.
- Add to Decurio I-III Invincible use and correct HP (retail video here, JP wiki here)
- Add to Miser Murphy a large endrain effect, status immunities, and correct HP (KnowOne capture here)
- Add to Eastern Shadow an Always Aggro mod (retail video here)
- Add to Mind Hoarder an endrain effect, status immunities, magic taken mod, correct attack speed, correct mobskill, and correct HP (Siknoz capture here)
The biggest change is the addition of a mixin for RoTZ bodyguarded NMs (specifically that Centurio XII-I uses in this PR). The other four such NMs (Meteormauler Zhagtegg, Coo Keja the Unseen, Meww the Turtlerider, and Bright-handed Kunberry) will be adjusted to use this new mixin in a separate PR. Some of these mobs already have some similar behavior but all have some incorrect logic, thus the future PR will fix these.
The PR is a draft for now to get feedback on the use of the mixin, also Siknoz is getting one more capture of Centurio to clarify some small points.
Steps to test these changes
Fight these mobs and compared to the captures or retail videos
Might be a silly question, but what happens to the bodyguards during a conquest tally on retail? Particularly if the region becomes no longer controlled by beastmen.
Might be a silly question, but what happens to the bodyguards during a conquest tally on retail? Particularly if the region becomes no longer controlled by beastmen.
That is unknown (as no capture for that situation on retail). The current logic of this PR is that they do not despawn in such a situation. Siknoz is currently checking their behavior if Centurio is killed (while they are still alive) and some variations of that situation but maybe too much of a pain to verify the change in conquest for now. Though I can ask him.
