server icon indicating copy to clipboard operation
server copied to clipboard

[LUA]Move PUP JA to jobUtils file

Open hooksta4 opened this issue 1 year ago • 1 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Moves all PUP Job Abilities to job_utils lua. The only change I made was https://github.com/LandSandBoat/server/blob/base/scripts/actions/abilities/cooldown.lua#L12

Where I added the check for if not automaton.

Looking at ways to do some trimming for repetitive code like checking for automaton. However, each of the onAbilityCheck for pup seems to have an additional check so it may need to stay how it is.

image

  • Updated based on the 3 CI check fails.

Steps to test these changes

Unlock pup and use the job abilities.

hooksta4 avatar Oct 17 '24 23:10 hooksta4

LGTM

xkoredev avatar Oct 18 '24 02:10 xkoredev

The CI failure isn't you, just need to rebase and you're good

WinterSolstice8 avatar Nov 13 '24 15:11 WinterSolstice8

The CI failure isn't you, just need to rebase and you're good

Thanks - just was able to get some time to do it. Doing CI's now.

hooksta4 avatar Nov 16 '24 18:11 hooksta4