server icon indicating copy to clipboard operation
server copied to clipboard

🐛 Mount command does not respect gained enmity

Open HaxPrime opened this issue 1 year ago • 6 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 11

Branch affected by issue

base

----== SystemMessage ==----
base-be17f7f3c3
Merge pull request #6121 from TiberonKalkaz/youre_a_wzard_galkas
Mon Aug 19 03:12:19 2024

client version
version 30240806_0

Steps to reproduce

  • Gain agro / enmity from a monster
  • Use mount

Video https://cdn.discordapp.com/attachments/1095358627520458832/1275201865424048290/2024-08-19_15-52-37.mkv?ex=66c507c8&is=66c3b648&hm=20a9270f0702272bdb6c0d7f862c49256d9756ced07dc4505be6d8463dd96c59&

Expected behavior

Players should not be able to use mounts with gained enmity.

You are unable to mount while on a monster’s enmity list. https://www.bg-wiki.com/ffxi/Category:Mounts

HaxPrime avatar Aug 19 '24 21:08 HaxPrime

What command are you refering to?

Xaver-DaRed avatar Aug 19 '24 21:08 Xaver-DaRed

What command are you refering to?

/mount crab example. Same results when using the abilities / mount player menu.

HaxPrime avatar Aug 19 '24 21:08 HaxPrime

You'll need to provide more detailed instructions, because it works fine on my end.

  1. !addallmounts
  2. Punch a mob in the face
  3. Disengage the mob (you can't call a mount while you're engaged)
  4. /mount crab
  5. You are rejected
image

I debugged it, and the check of NotorietyContainer (the reverse enmity container) works as expected

image image

zach2good avatar Aug 19 '24 22:08 zach2good

You'll need to provide more detailed instructions, because it works fine on my end.

Thanks for the quick reply and debug information. To further elaborate on this issue it might have to do with how the enmity is gained, to perform the bug you must not take action vs the monster, passively gain enmity / detection. I'll list more detailed steps to recreate;

  1. !changejob sam 20
  2. !pos 483.43 25.00 484.36 109 -- Pashhow Marshlands
  3. Passively gain aggression from the goblins here, take no action vs them.
  4. /mount crab

Thanks for the time guys.

HaxPrime avatar Aug 19 '24 23:08 HaxPrime

This is probably due to the supertanking enmity changes in #5632. Passive aggro and linking doesn't add to the enmity list any more, just causes the mob to engage a target.

cocosolos avatar Aug 20 '24 16:08 cocosolos

Yup, that'd do it

zach2good avatar Aug 20 '24 17:08 zach2good