server icon indicating copy to clipboard operation
server copied to clipboard

[BCNM] Make Ifrit TBF and TSTBF more retail accurate

Open TracentEden2 opened this issue 1 year ago • 2 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adjusts Ifrit Prime for Trial by Fire aka TBF and Trial Size Trial by Fire aka TSTBF to be more retail accurate.

This is done by first splitting the TBF Ifrit and TSTBF Ifrit into two separate luas (as they have different logic and having separate helps with readability and understandability).

TBF is given several retail accurate mods including status immunities, fire absorb, enfire effect, udmgphy, udmgrange, and sight and magic aggro ranges. The TBF skill list was corrected by removing Inferno (which it was using as normal skill) and adding Burning Strike and Fire VI. Also the Ifrit mystic avatars (from temenos) that were also using the TBF skill list were changed to use a different Ifrit skill list that better aligns with the fact that they can use any Ifrit skills.

TSTBF is given the same immunities, udmgphy, udmgrange, and sight and magic aggro ranges as TBF. However the enfire damage level was changed to be accurate to retail videos (as no captures exist), 3000 TP is given on engage as retail videos show mobskill use on engage. And a LIGHT_MEVA of -35 is given so that searing light resist rate roughly matches that seen in retail videos (24/27 unresisted searing lights from my checking).

TBF, TSTBF, and ASA were given the correct job of drk/blm (like player avatars).

The changes were based on captures including here and here, a personal capture I will upload, trial by fire videos like here and here, and trial size trial by videos (of all different avatars) for searing light resist rate and MEVA change. Also mystic avatar change based on capture here.

This is prequel to a series of PRs that will be adding the Waking the Beast (WTB) quest starting with Ifrit. However to keep PRs more compact I wanted to add these changes first and then Ifrit WTB in a separate PR.

Steps to test these changes

Fight TBF and TSTBF to check changes

TracentEden2 avatar Aug 17 '24 09:08 TracentEden2

This has conflicts. Rebase it whenever you can and it will be ready to go.

Xaver-DaRed avatar Sep 01 '24 10:09 Xaver-DaRed

This has conflicts. Rebase it whenever you can and it will be ready to go.

Yep, I fixed the conflicts now, thanks!

TracentEden2 avatar Sep 01 '24 17:09 TracentEden2