server icon indicating copy to clipboard operation
server copied to clipboard

[Lua] Add ZNM NPC to unique_event

Open hooksta4 opened this issue 1 year ago • 3 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Place holder for ZNM NPC's Sanraku and Ryo in unique_event. Will determine which dialog players will get upon talking to either NPC.

Steps to test these changes

None at this time.

hooksta4 avatar Jun 20 '24 23:06 hooksta4

These aren't fast-moving files, so why not just do the rest of the logic now too? Ekokoko is a full example of how this system works.

zach2good avatar Jun 21 '24 09:06 zach2good

So I don't forget it.

hooksta4 avatar Jun 21 '24 11:06 hooksta4

To clarify what I want from this PR: The latching logic for "I have spoken to Sanraku for the first time", and "I have spoken to Sanraku for subsequent times" - which is just a single if/else block if memory serves.

Using a single-line PR as a way for you not to forget that a feature exists is pointless.

zach2good avatar Jul 02 '24 10:07 zach2good

It's been 45 days since this PR you wanted to use as a reminder was opened, and there hasn't been any movement on it. It's just a single line - I'm going to close it. Feel free to return and do the first-talk chat changes with Sanraku (and his apprentice, whoever that was?) and back it with the uniqueEvent system.

zach2good avatar Aug 05 '24 14:08 zach2good