server icon indicating copy to clipboard operation
server copied to clipboard

Moved Ranger ability Lua to jobutils

Open andeluvian opened this issue 1 year ago • 6 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do? (Please be technical)

All job abilities of the ranger have been moved from scripts/actions/abilities/ to scripts/globals/job_utils/ranger.lua

Steps to test these changes

Go into the game Make a level 99 or 75 ranger Test each job ability and see if they work correctly

Special Deployment Considerations

andeluvian avatar Jun 05 '24 17:06 andeluvian

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

github-actions[bot] avatar Jun 05 '24 17:06 github-actions[bot]

Draft while i am self testing these changes

andeluvian avatar Jun 05 '24 17:06 andeluvian

Tested on local server on ranger 75 all abilities worked. Will cleanup work and made the necessary changes according to PR and helpful comments

andeluvian avatar Jun 09 '24 20:06 andeluvian

squashed commits

andeluvian avatar Jun 11 '24 07:06 andeluvian

Kicked CI so you can see what's still left to do. There's no need to re-tag people for review, if they've interacted with your PR and you re-push I think everyone gets an email.

zach2good avatar Jun 15 '24 13:06 zach2good

(I do, at least 🤷‍♂️)

zach2good avatar Jun 15 '24 13:06 zach2good

This PR is failing CI. You need to remobe the tabs from the code. Tabs -> 4 spaces

Xaver-DaRed avatar Jul 15 '24 13:07 Xaver-DaRed

Replaced by https://github.com/LandSandBoat/server/pull/6070

zach2good avatar Aug 04 '24 08:08 zach2good

In future can you not submit PRs from your fork of ASB. They are so diverged at the moment that they're not compatible, even if they seem like it. It also means that maintainers can't easily swoop in and make tiny changes on your behalf to get PRs over the line.

zach2good avatar Aug 04 '24 08:08 zach2good