[Quest]RNG AF1-3 Series Conversion IF
[Quest]RNG AF1-3 Series Conversion IF
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits. I realize this is a very large PR. My logic behind putting them all into one, besides it being a series, is the good chunk of the quests revolve around Perih Vashai, Koh Lenbalalako, Kapeh Myohrye, and Muhk Johldy. It seemed logical for testing to do them all at once.
What does this pull request do?
Converts the RNG AF quests 1-3 series to Interaction Framework.
-Scavenge now uses Quest framework var format and enum'd zone and item. -Added a quest complete section and a check for next quest because the dialog changes on complete quest after each one except for the last. -Converts Sin Hunting (AF1) to IF. -Moves default dialog to DefaultActions where appropriate. -Converts Fire and Brimstone (AF2) to IF -Adds dialogs to NPC's from near by NPC's that was previously not there. -Adds zoning requirement before next quest is available. -Players were previously able to select any Gravestone and complete that portion of the quest. They now will get correct dialog if they chose the incorrect one. Only allowing the correct Gravestone to produce the progressing event. -Players must have zoned from Batallia Downs as per capture in order to get the cutscene. -Converts Unbridled Passion (AF3) -Added dialog for different parts of mission based on progress. -Based on capture, depending on where player zoned in from, changes the cs but still progresses the same. -Allows players to still complete the quest even if they don't gather the 99 ice arrows that are optional. -Adjusted The Fanged One to the correct dialog after quest complete but before accepting any other quest as the NPC dialog changes based on progress in the quest series. -Removed all NPC lua logic invovled with the quest series.
Capture Capture Capture Capture
Steps to test these changes
Set job to RNG level 50 or higher and complete the quests. The info has all POS for particular points of interest.
One of these days I will be able to rebase without having some weird issues.
Reference: https://github.com/LandSandBoat/server/pull/5822