[QUEST] For the Birds

[jamesbradleym]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements quest For the Birds Modified from ASB with additional/corrected dialog, proper mob kill check, corrected ki cycle,

Based on ASB Capture

Steps to test these changes

[Xaver-DaRed]

I have some questions:

• What happens if you loose/warp out the quadav fight? You lost the KI presumably. Can you get it again? And if you dont, does talking to the npc after that retrigger the fight anyway?
• Shouldnt the prog variable when killing all 4 quadavs only progress if you dont have the KI? Or else, another player could just join the fight with the KI and it wouldnt be ever taken away.

I did some research and it does seem each party member must individually check the npc to each trigger the fight. So only the one poping the mobs is the one getting the credit.

I think this needs another capture for the edge-cases and fail status.

[jamesbradleym]

I have some questions:

• What happens if you loose/warp out the quadav fight? You lost the KI presumably. Can you get it again? And if you dont, does talking to the npc after that retrigger the fight anyway?
• Shouldnt the prog variable when killing all 4 quadavs only progress if you dont have the KI? Or else, another player could just join the fight with the KI and it wouldnt be ever taken away.

I think this needs another capture

The player can return to Koblakiq to receive another Glittering Fragment if they lose or warp out of the Quadav fight (line 85)

Interesting point, however if it's changed so you progress if you don't have the KI, then another player could join the fight without the KI (for instance if they recently failed a fight) and progress without having it?

I suppose it would be simple enough to do a check if the player has the KI at the end of the fight and if so remove it?

[Xaver-DaRed]

It should not progress for the rest of the party members, is my point. Only the one that pops the NMs gets to progress the quest.

So an additional check is needed on mob death. I'll point it out... One sec

[jamesbradleym]

It should not progress for the rest of the party members, is my point. Only the one that pops the NMs gets to progress the quest.

So an additional check is needed on mob death. I'll point it out... One sec

Ah, I see. So then would it be appropriate to set a var on GeFhu for last pop to indicate who would progress from mob death?

[jamesbradleym]

Closing this PR to reduce open PRs and prevent staleness—will revisit.