server
server copied to clipboard
🐛 Entry to instance encounters (mostly) doesn't handle failed entry requirement checks
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Branch affected by issue
base
Steps to reproduce
My work here made me realize that all calls to xi.instance.onEventUpdate
(which checks the requirements of entry) do nothing with the return, excepting Antiquated_Sluice_Gate
even that one doesn't actually handle a return of false properly, all of these will leave the initiator stuck in the entry event, waiting for an instance callback that will never come because someone in the party, within range, didn't meet the requirements
They should all have some kind of logic similar to _20m
. Note that none of these actually work like the Nyzul entry npc as the event doesn't continuously check for a valid status, but checking if a return of false surely can be cleanly handled to exit the player out of the client-locking event