🐛 Dynamis TE key items preserved under specific circumstances

[MowFord]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Dynamis TE key items:

• CRIMSON_GRANULES_OF_TIME
• AZURE_GRANULES_OF_TIME
• AMBER_GRANULES_OF_TIME
• ALABASTER_GRANULES_OF_TIME
• OBSIDIAN_GRANULES_OF_TIME

are sometimes left over from a previous dynamis run. I was looking into it when i came across this newer bug https://github.com/LandSandBoat/server/pull/5433, but I believe this underlying issue is due to the key items being deleted by the oneffectlose logic, which isn't called if you log in after the dynamis buff duration has expired

i.e. Steps to reproduce:

• enter dynamis not as a gm, via normal means
• kill a TE
• logout
• wait longer than the remaining duration of the dynamis buff
• log in (if you are a gm, you'll get the dynamis buff again and stay in zone)
• you'll get kicked from dynamis, but the TE key item will not be removed

Expected behavior

[github-actions[bot]]

✨ Thanks for the report! ✨

This is a friendly automated reminder that the maintainers won't look at your report until you've properly completed all of the checkboxes in the pre-filled template.