🐛 Subjob restriction persists past losing buff (somewhat)

[MowFord]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

The GetSJob() charutil function returns zero if you have the subjob restriction effect.

This same function is used in SaveCharStats(), which then commits your subjob ID to the database. Visiting a moogle can update your subjob after losing the buff, but I think perhaps SaveCharStats() should just be updated to not include sjob if the effect is active? The function would look clunky but would solve this problem... something like this:

Expected behavior

[github-actions[bot]]

✨ Thanks for the report! ✨

This is a friendly automated reminder that the maintainers won't look at your report until you've properly completed all of the checkboxes in the pre-filled template.