server icon indicating copy to clipboard operation
server copied to clipboard

[Quest]Sin Hunting RNG AF1 to IF

Open hooksta4 opened this issue 1 year ago • 1 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts Sin Hunting quest to Interaction Framework.

  • Implemented several DefaultActions that were missing for associated NPC text.
  • Added message ID for accurate messages
  • Removed NPC lua functions related to Sin Hunting There is a dialog event 542 that will show up during dialog on complete due to it checking for var < unbridledPassionCS which is always true. This will resolve when that quest is converted. At this point it is more effort to fix that just to be converted shortly.

Converts quest Sin Hunting.

Steps to test these changes

With RNG set as main job and over level 40, talk to Perih Vashai in Windurst Woods. Dialogs change for guards Muhk and Kapel. Their default messages also change after quest completion.

hooksta4 avatar Apr 11 '24 15:04 hooksta4

@Xaver-DaRed what do you think about these changes?

hooksta4 avatar Apr 13 '24 01:04 hooksta4

Just waiting for The Fanged One to be merged and then I can fix this one.

hooksta4 avatar May 13 '24 13:05 hooksta4