server icon indicating copy to clipboard operation
server copied to clipboard

[lua] snake eye to automatic 11 only when previous roll is 5+

Open MowFord opened this issue 11 months ago • 1 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Snake eye effect should give a chance to automatic roll 11 only when the roll power is 5+, old code was checking the previous roll's effectID

Steps to test these changes

Fully merit snake eye and see that you only ever roll 11 when previous roll power is 5+

MowFord avatar Mar 11 '24 23:03 MowFord

Correction it wasn't comparing the old effect id, it was comparing the current roll power, i.e. Chaos power 6 is, etc. Regardless, it wasn't using the roll count

MowFord avatar Mar 12 '24 00:03 MowFord