server
server copied to clipboard
[Quest] fix logic and messages for quest Your Crystal Ball
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
Closes: https://github.com/HorizonFFXI/HorizonXI-Issues/issues/1841 Capture
Updates the logic gates for Rockwell to prevent odd behavior: No longer gives player a divination sphere if they interact with Rockwell before trading. Only gives divination sphere when a lens has been placed in the rockwell previously/since last reward. Adds trade check that matches trade dialogue ("You cannot submerge more than one Ahriman lens at a time.")
Updates message + item references so interaction dialogue includes item text. Adds progress() to message so default messages are not called.
Updates default message to pool of water Adds follow up text about fortune after quest completion.
Steps to test these changes
!addquest 3 9 !additem 557 (ahriman lens)
interact with Rockwell
NOTE
Difference between retail and era: Submersion wait in era is JST Midnight, current retail is ~ 30seconds
@claywar Sorry to bug you on all these, just trying to clear my older PRs 😅 Let me know if you need anything else here.
@claywar Sorry to bump this again, anything else need addressing or is this good to go?