server icon indicating copy to clipboard operation
server copied to clipboard

[Lua] add fame commands to LSB

Open jamesbradleym opened this issue 11 months ago • 5 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds getfame and setfamelevel commands as implemented by @CriticalXI & @paladindamarus in ASB commit 00d8f06, reformatted for LSB

Steps to test these changes

!getfame !setfamelevel

jamesbradleym avatar Mar 02 '24 21:03 jamesbradleym

please amend your commit title -- add fame commands to LSB --author "Criticalxi" has some extra bit at the end that shouldn't be there

WinterSolstice8 avatar Mar 16 '24 21:03 WinterSolstice8

please amend your commit title -- add fame commands to LSB --author "Criticalxi" has some extra bit at the end that shouldn't be there

~~I think I'm misunderstanding this note from the development guide~~ Didn't misunderstand, just didn't do it correctly

Amended!

jamesbradleym avatar Mar 16 '24 23:03 jamesbradleym

I'd very much like to see the actual fame area enumerations we already have get used, similar to how the keyitems command uses the keyitem enumeration. Its easy to miss that quest areas are enumerated because they live in the quest global still and not the enum folder yet.

TeoTwawki avatar Mar 16 '24 23:03 TeoTwawki

I'd very much like to see the actual fame area enumerations we already have get used, similar to how the keyitems command uses the keyitem enumeration. Its easy to miss that quest areas are enumerated because they live in the quest global still and not the enum folder yet.

Can do!

jamesbradleym avatar Mar 16 '24 23:03 jamesbradleym