server icon indicating copy to clipboard operation
server copied to clipboard

🐛 Mob AEs with 100% Proc Rate shouldn't be level corrected

Open CatsEyeXI opened this issue 1 year ago • 1 comments

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 10

Branch affected by issue

base

Steps to reproduce

entity.onAdditionalEffect = function(mob, target, damage)
    return xi.mob.onAddEffect(mob, target, damage, xi.mob.ae.ENFIRE, { chance = 100, power = 35 })
end

Turn on debug prints in mobs.lua, see that the chance returned is actually 15.

Expected behavior

100% chance should be a 100% chance, not 15.

CatsEyeXI avatar Feb 05 '24 00:02 CatsEyeXI

specifically its 15 in this print https://github.com/LandSandBoat/server/blob/defa464f7c1746277ad1e37fbe495c950d941135/scripts/globals/mobs.lua#L484 because the players level was 18 levels above the monsters level

the correction of "chance" should only occur when it is less than 100% but its being done anyway

TeoTwawki avatar Feb 05 '24 00:02 TeoTwawki