server icon indicating copy to clipboard operation
server copied to clipboard

DNC job ability: Contradance

Open MowFord opened this issue 1 year ago • 2 comments

  • Doubles curing power of next waltz
  • Converts Healing Waltz to AoE

I affirm:

  • [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • [x] I have read and understood the Contributing Guide and the Code of Conduct.
  • [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Codes the DNC ability: Contradance

Simple enough. Though one small annoyance is getting the bonus for all targets of divine waltz (aoe cure)

I did it via a timer to delete the effect 100ms after the aoe resolves all the targets. This works but unsure if there's a different way LSB would prefer it done.

image

image

image

Steps to test these changes

Use the contradance ability, test waltzes for bonus and that the effect wears on use

MowFord avatar Dec 02 '23 00:12 MowFord

animation is Divine Seal: https://www.youtube.com/watch?v=7GEaEOCDuKY&t=833s

MowFord avatar Dec 02 '23 00:12 MowFord

image Packet from retail

WinterSolstice8 avatar Dec 02 '23 00:12 WinterSolstice8