Skillchains occur even when weaponskills miss
- [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
- [x] I have searched existing issues to see if the issue has already been opened
- [x] I have checked the commit log to see if the issue has been resolved since my server was last updated
- [x] I have read the Contributing Guide
- [x] I have specified what branch this happens on branch: freedom
Additional Information (Steps to reproduce/Expected behavior) : If a WS misses, another can close with a WS to form a SC. If a WS hits (or misses), another can close with a missing WS and it does 0 damage.
In retail if either opening or closing WS misses, no SC is triggered.
This issue came up in the Canaria discord recently. Mostly centered around observations of WS chains firing off with 0 damage, but we did't have confirmation on whether those chains spawned from WS landing for damage, landing for 0, or were flat out missed. While gathering some CP tonight, I took it easy and watched the log for once and managed to capture some examples, which I will past grabs in here marked up to highlight the hit/miss and resulting chains.
This was fairly easy to replicate in an SoA zone at level 99, as it is easy to isolate mobs in the +3-5 level range gap where trust hit rate can be pretty low without any debuffs, and you really only need to offset the ACC/EVA comparison by around 10 or 12 points to ramp up the hit rate to ensure a closing WS lands (when testing this out, 2 or 3 quicksteps flipped it around nicely on 102-105 level mobs).

This was fixed by: https://github.com/LandSandBoat/server/pull/2441
This was fixed in PR 2441