server
server copied to clipboard
Port Eden's Absolute Virtue impl (2H locking mechanic)
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
I started writing an impl for 2H locking for AV to help horizon out (see here: https://gist.github.com/zach2good/8851ffc2609ddec37669b861fe5fa3ed), but then I had a look at Eden's impl and it's much cleaner - so I started porting it.
There's no "secret sauce", everything is based off of notes, wikis, videos, etc.
Locking mechanic now working as expected:
Other than the actual AV script, the rest is awesome.
As for AV itself, it could use some cleaning and verbosity BUT the actual logic looks correct. I would say this is one of those things that needs to be tested in production. I am willing to get this tested and adjusted if it gets merged.
This wont actually enable AV anyway (we have it dissabled atm).
Also, It would be recommendable to look at their database to get possible resistances, SDTs and such in case we dont have them/have them wrong
This wont actually enable AV anyway (we have it dissabled atm).
Do we though? I haven't looked very hard, but this is in JoL's script:
entity.onMobDespawn = function(mob)
if math.random(1, 100) <= 25 then -- 25% chance to spawn Absolute Virtue
SpawnMob(ID.mob.ABSOLUTE_VIRTUE)
end
end
I THOUGHT we had it disabled.
To try and get this over the line, how about we mark this as experimental and make it un-spawnable unless you go in and enable it? Then hopefully someone more gameplay minded will pick up the slack (we always pray, sometimes it happens)