🐛 [Trusts] 7th party member possible

[Skerxan]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

• Have 5 players in your party plus one trust (Full pt)
• Invite a 6th player (I used the /pcmd add command in the same zone)
• See the 6th player take the pt spot of the Trust but the Trust is still up and about -- TParty plugin showed that the Trust moved to an invisible 2nd pt like an alliance

Now, I dont know if this is LSB base or CatsEye Crystal Warrior specific issue. I still gonna report it regardless.

Expected behavior

Not really sure how retail handles it but it should be either:

• Trust gets released(unsummoned)
• or game tells you, you can't add another player to the pt because its full

[CatsEyeXI]

Yeah I've seen this...

[laernumoretz]

I had a full 6 player party and hit my trust macro on accident, and it summoned all 5 trusts…..lol

Not sure if it was a factor but i had togglegm enabled at the time. Totally broke the UI.

did some more testing. It continued to let me summon more trusts. I stopped once I got to 12 because the UI was getting crazy. Have a feeling it wouldve let me keep going

[zach2good]

GMs aren't subject to the size checks in trust.lua:

xi.trust.canCast = function(caster, spell, notAllowedTrustIds)
    -- Trusts must be enabled in settings
    if xi.settings.main.ENABLE_TRUST_CASTING == 0 then
        return xi.msg.basic.TRUST_NO_CAST_TRUST
    end

    -- GMs can do what they want (as long as ENABLE_TRUST_CASTING is enabled)
    if caster:getGMLevel() > 0 and caster:checkNameFlags(0x04000000) then
        return 0
    end