server
server copied to clipboard
LandSandBoat
Implements Quest: Knocking on Forbidden Doors
I affirm:
- [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
- [x] I have read and understood the Contributing Guide
- [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits
What does this pull request do?
Adds quest: Knocking on Forbidden Doors (Tavnazian Safehold) On quest completion: Adds ability to purchase, trade, and pose mannequins
Steps to test these changes
Complete "Behind the Smile" in Tavnazian Safehold, then talk to Enaremand to flag this quest. Once complete, you can talk to Fyi Chalmwoh in Mhaura to purchase, trade, and pose mannequins.
TODO: The NM "Alsha" requires the ability to cast damaging magic on herself, which the current core prevents from doing. Future updates will be required to work around this. This function is not included in the update - I want to get the mannequin functions working first, and fix the NM later.
@paladindamarus I know github allows it, but please leave it to us to use the resolve button on comments. Its less confusing for us when we review.
11 Oct - All requested updates made, unless I missed any in the previous change requests.
11 Oct - All requested updates made, unless I missed any in the previous change requests.
did you get the PChar check Zach asked for here? https://github.com/LandSandBoat/server/pull/2917/files#r991440146
Looks like CLuaBaseEntity::getMannequinPose(uint16 itemID) is still missing the PChar != nullptr check based on what I see here in the PR
Ahh good catch. I picked it up in the setMannequinPose but not get.
However -- I did realize that I could have done better with the logic. I edited both functions, and I don't need to create a PItem intermediary this way. If not, I can revert back to the old way and then re-apply the PChar checks.