🔨 More control over additional effect proc chance

[CriticalXI]

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
• [x] I have read and understood the Contributing Guide

Describe the feature

I was hoping to see if we could have the additional effect system adjusted to allow for more control over how a weapon's additional effect procs. I could be missing or wrong and there is already a way to do this, but as of right now I haven't been able to find a way. As of right now it seems that the system is built out that either it procs or it doesn't purely based just off of the ITEM_ADDEFFECT_CHANCE mod.

This causes issues for a couple items that I've ran into so far trying to get additional effects functioning for some items.

https://ffxiclopedia.fandom.com/wiki/Chicken_Knife This is one example, the chance to proc should vary depending on the level difference between you and the mob.

https://ffxiclopedia.fandom.com/wiki/Treat_Staff Another example that the proc chance should be blocked depending on time and moon, or an event is active.

As far as I understand it currently, these are impossible to get working properly in the current system.

[TeoTwawki]

I guess you missed my response in discord, these would happen via item_latents

[CriticalXI]

I still haven't been able to find a way to make Chicken Knife even looking into the item_latents as there isn't any that proc depending on a check on the mob. Do you have an example of one doing this? I was also curious how to make the visible proc animation happen with a latent too.

[TeoTwawki]

I've been held up while diagnosing some issues with the latent system, but I have several that will be there soon, chicken knife included. Additionally the current handling of ranged additional effects is going to soon change from just checking if the item is ranged to looking for a modifier, so that dStat and level checks can optionally be applied to any weapon. Since Add effect Flee is the only one to allegedly use the /check value and the latent system is proving untrustworthy, I am doing the chicken knife (and also Shijo) myself in an upcoming pr with some script logic to optionally accommodate it.

[TeoTwawki]

I've assigned myself this, and will get back to you soon

[TeoTwawki]

I've assigned myself this, and will get back to you soon

And Maury meme determined that was a lie (unintentional)

😢

Due to past decisions way back in DSP what I wanted to do proved very annoying to accomplish. I've fixed some of it, the rest is still in the pipes (I'm just going through all my still open things I have assigned to me tonight). I apologize its been so long.