server icon indicating copy to clipboard operation
server copied to clipboard

[NPC] Added more pathing to NPCs in Windy Woods and Whitegate

Open kaincenteno opened this issue 3 years ago • 3 comments

I affirm:

  • [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • [x] I have read and understood the Contributing Guide
  • [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

What does this pull request do?

it adds 2 missing requirements for patroling npcs and adds coordinates and logic to other 3 more NPCs making the zones lively :D

Steps to test these changes

Login and have fun watching them be alive =)

kaincenteno avatar Aug 12 '22 16:08 kaincenteno

[🤞] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

Please test your code.

zach2good avatar Aug 12 '22 16:08 zach2good

[🤞] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

Please test your code.

it's been tested and working on xiweb 😄 I saw the emoji on other PRS and thought it looked like a fun way to do the checkmarks. Let me change it then sorry for the confusion 😸

kaincenteno avatar Aug 12 '22 17:08 kaincenteno

[crossed_fingers] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

Please test your code.

it's been tested and working on xiweb smile I saw the emoji on other PRS and thought it looked like a fun way to do the checkmarks. Let me change it then sorry for the confusion smile_cat

on certain occasions, there are changes that either cannot legitimately be tested or are so simplistic as to be silly to devote test time to and we are extremely confident are good: such as correcting a typo in a comment. in such cases people have jokingly thrown in an emoji to acknowledge that no, it really wasn't.

(the "and" is really important there)

TeoTwawki avatar Aug 13 '22 00:08 TeoTwawki