Add mod NULL_BREATH_DAMAGE

[illzbee]

I affirm:

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have read and understood the Contributing Guide
• [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

What does this pull request do?

Adds mod NULL_BREATH_DAMAGE to occasionally nullify breath damage

Steps to test these changes

Take breath damage with porog cask+1 mods equiped

[TeoTwawki]

#2338 had unanswered questions, which is why I had not simply done this. Retail accurate behavior needs know, and I've not seen a single item that says it does this specifically without also nulling another damage type. For all I know, we need a single mod that nulls any and all types of damage -or- the existing element ones should also be covering breath damages of their element. I said as much both hen I asked you to open the issue, and again when you didn't include that info in the issue and had to post it a 2nd time. Here it is a 3rd time:

things that literally cannot be done we're much more forgiving on than things people simply didn't do. use physical and magic nulls, and raise an issue calling out this item by name so it isn't forgotten. I had actually just posted to Xaver-DaRed back on the discussion about elemental nulls, because I think unlike the generic magic one I am not sure they should care about the source of an element. But we should probably just one mod that covers "all types of damage". It's also possible breath bypasses this mechanic.

And no, not having this mod does not mean your pr can't be merged.

[Xaver-DaRed]

I would also request that this new modifier is added to this documentation file https://github.com/LandSandBoat/server/blob/base/documentation/mods_by_id.txt

[WinterSolstice8]

there's no evidence (in english text, mind you, occasionally the japanese text reveals more than what we got) that there is a null breath damage modifier on any gear. What is this attempting to solve? what item, ability, etc wants this?

[illzbee]

https://github.com/LandSandBoat/server/pull/2307#issue-1306977798

For the Poroggo Cass. +1 “ Occasionally ignores damage taken “

[TeoTwawki]

#2307 (comment)

For the Poroggo Cass. +1 “ Occasionally ignores damage taken “

That doesn't actually answer anything. Nor does it indicate a need for null breath damage. its more indicative of a need for a null everything modifier if anything.

[TeoTwawki]

to be as simple as I can be:

will Poroggo Cass. +1 nullify any damage type form any source?

will a different item that nulls just fire, also nullify fire breath or eruca's incinerate?

[TeoTwawki]

the most likely scenario is not a need for breath specific modifier, its an "all damage" one, and maybe tweaks to the existing element ones

[TeoTwawki]

but none of it matters till someone takes time to go test it on the retail game

[illzbee]

I would also request that this new modifier is added to this documentation file https://github.com/LandSandBoat/server/blob/base/documentation/mods_by_id.txt

Added in thanks.

[WinterSolstice8]

It sounds like all we need to do is test if "ignores damage" means what it says it means. If you have this on retail you could test it in brenner with Spirits Within (typeless breath damage) and against other breaths like Incinerate from Erucas, or really just any source. We can't just trust the text to do what it says it does, SE's fooled the playerbase quite a bit with bad descriptions like this.

fwiw, there are damage sources that aren't magic, physical or breath. The description implies "all" sources, but it's not easy to get hit by the sources that aren't those 3 -- these are things such as Unfaltering Bravado from Kyou which doesn't appear to be able to be mitigated by MDT/BDT/PDT, but might work with this. The problem isn't so much adding this mod in the PR as it is understanding which one we actually need from testing, if any. It may not even null breath damage.

[TeoTwawki]

Dont see how thats not answering that question but meh.

It articulated no reasoning at all and simply linked to an item that may not even be needed for. That's how.

D. adding NULL_ALL_DMG would be adding a line of code to more damage typed in battle utilities then just one on breath for just 1 item to use...

Except we may need to cover other edge cases that just adding breath with the other 2 might not.

Edit: winter said it better.

[zach2good]

This is getting handled in another PR, closing