server icon indicating copy to clipboard operation
server copied to clipboard

Transport Animation Fixes + Mhaura/Selbina Pirate Event

Open The-Aerec opened this issue 2 years ago • 2 comments

I affirm:

  • [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
  • [x] I have read and understood the Contributing Guide
  • [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits

Co-Authored-By: Seztor + Mattyg

What does this pull request do?

  1. Corrects Animations, Animation Directions, Animation Duration for: Airships and Ships
  • Animations now properly show for all transports: For example a ship leaving selbina will have the zone animation timed correctly play during the transport event from selbina -> mhaura
  1. Corrects Docking / Departing Animations for Mhaura / Selbina Ships

image

  1. Adds Pirate event and scripted ship mobs.
  2. Adds safety check for players who logout/crash on Mhaura / Selbina Ships, setting their positions to a safe spot on login.
  3. And More~

Steps to test these changes

Ride some boats and airships!

The-Aerec avatar Jul 01 '22 23:07 The-Aerec

Could we make a new entity type (from NPC I guess?) and store them there?

we actually have one already, just needs built out farther

https://github.com/LandSandBoat/server/blob/d0212ae023500827cb16d5066ad8449cfdab7231/src/map/entities/baseentity.h#L39

TeoTwawki avatar Jul 06 '22 12:07 TeoTwawki

Could we make a new entity type (from NPC I guess?) and store them there?

we actually have one already, just needs built out farther

https://github.com/LandSandBoat/server/blob/d0212ae023500827cb16d5066ad8449cfdab7231/src/map/entities/baseentity.h#L39

Yeah, this is the way

zach2good avatar Jul 06 '22 12:07 zach2good