server
server copied to clipboard
LandSandBoat
Implement A Shantotto Ascension Mission 1 through 5
I affirm:
- [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
- [x] I have read and understood the Contributing Guide
- [x] I've tested my code and the things my code has changed since the last commit in the PR, and will test after any later commits
What does this pull request do?
Adds mission files along with all relevant changes needed for these missions for A Shantotto Ascension mission 1 through 5.
Steps to test these changes
Follow the steps for ASA Missions outlined here: https://ffxiclopedia.fandom.com/wiki/Category:A_Shantotto_Ascension_Missions
Just dropping a note here about issue #426, Enchanted Ink recipe not in synth_recipes.sql, which blocks progression in ASA3 (can't craft the enfeebling kits). Will need to verify those ASA3 craftables are available when these go live.
I've added the recipe on this PR if you see at the bottom of the list of changes.
Think that was the only posted issue still open regarding ASA. Seems to me the coffer ones got closed ages ago. Just wanted to make sure it was noted so it can all get wrapped up and closed properly.
So much to be reviewed on these... IDK how you guys do it.
I have fixed nearly all the requested changes. Final thing to undraft this PR is correcting two of the missions to be repeatable.
I am unsure on how to appreach the repeatable part of these missions. The other examples in the code I believe you actually pick up the mission again to repeat it, but for ASA its more that you can repeat the BCNMs and receive KIs from the NPC in Norg again but you don't need to have the mission active to do so.
Claywar had mentioned adding a check to see if the mission is complete but I'm not sure how to implement that.
You'll need a new section where the check involves player:hasCompletedMission(), or modify a previous check in that block if there's no difference.
Will review this again, but can you please ensure that this code was tested using the branch here? Just noticed the check-box isn't marked for that.
Resolved merge conflicts and removed canUseAbility util as Aerec has split this off into its own PR.
