LambDynamicLights icon indicating copy to clipboard operation
LambDynamicLights copied to clipboard

Lagging while walking in Minecraft 1.18 with fancy dynamic light

Open EmanuelLopesS2 opened this issue 3 years ago • 17 comments

To Reproduce Steps to reproduce the behavior:

  1. Just have the mod loaded and walk with the dynamic light in fancy

Expected behavior Not lagging

Desktop (please complete the following information):

  • OS: Windows 11
  • Minecraft 1.18
  • Fabric Loader version 0.12.6-1.18]
  • Mods fabric-api-0.43.1+1.18, cloth-config-6.0.42-fabric, lambdynamiclights-2.1.0+1.17, modmenu-3.0.0]
  • Version 1.18

it works fine with the fastest option

EmanuelLopesS2 avatar Nov 30 '21 21:11 EmanuelLopesS2

Does this happen when not holding any light sources? If you emit light, it's sadly a consequence of chunk rebuilding, I can't really do anything about this, you'll have to use Sodium once it's available.

LambdAurora avatar Nov 30 '21 21:11 LambdAurora

I have same issue even using sodium (mc1.18-0.4.0-alpha5)

bailmast avatar Dec 01 '21 00:12 bailmast

I have same issue even using sodium (mc1.18-0.4.0-alpha5)

About 38 FPS when I'm holding and about 260 when I'm not holding

bailmast avatar Dec 01 '21 00:12 bailmast

I have same issue even using sodium (mc1.18-0.4.0-alpha5)

About 38 FPS when I'm holding and about 260 when I'm not holding

If this is not a problem of LamdDynamicLights, I hope it will be fixed in the stable version of sodium

bailmast avatar Dec 01 '21 01:12 bailmast

Im also having this issue.

https://user-images.githubusercontent.com/57187871/144393553-13b4bd2f-029c-4f4c-b439-86053e78933b.mp4

There's a video that shows it happening. Also heres my F3 Screen image

It also seems to happen with normal light sources as well, like tnt, torches placed on the ground, light blocks, creepers, etc

DerpDerpling avatar Dec 02 '21 09:12 DerpDerpling

Does this happen when not holding any light sources?

Yup, this is the experience in my testing while running the Sodium alpha build for 1.18. If I'm holding any light source, I run into micro stuttering while moving. As soon as I put that source away, the stutters are gone. I've not noticed any issues, however, with entities that have been left on the ground.

Juvenall avatar Dec 03 '21 14:12 Juvenall

Does this happen when not holding any light sources?

Yup, this is the experience in my testing while running the Sodium alpha build for 1.18. If I'm holding any light source, I run into micro stuttering while moving. As soon as I put that source away, the stutters are gone. I've not noticed any issues, however, with entities that have been left on the ground.

I'm having the same issue with LambDynamicLights v2.1.0+1.17 and sodium-fabric-mc1.18-0.4.0-alpha5+build.9

JonathanTippy avatar Dec 08 '21 04:12 JonathanTippy

Same here. LambDynamicLights v2.1.0+1.17 and sodium-fabric-mc1.18-0.4.0-alpha5+build.9

ThatOmicron avatar Dec 23 '21 19:12 ThatOmicron

Honestly, I've been using Optifine and dynamic lighting for as long as I've been playing the game and have never noticed any drops in performance. There's an almost 80% FPS drop with your mod. That is excessive and unacceptable.

simonjonnemeth avatar Dec 30 '21 04:12 simonjonnemeth

Honestly, I've been using Optifine and dynamic lighting for as long as I've been playing the game and have never noticed any drops in performance. There's an almost 80% FPS drop with your mod. That is excessive and unacceptable.

Optifine and LambDynamicLights use different methods for creating dynamic lighting. Optifine uses a shader, while LDL rebuilds the chunk each time there's a movement. Chunk rebuilding is more expensive than a shader, but it's much easier to maintain.

Oliver-makes-code avatar Dec 30 '21 04:12 Oliver-makes-code

Honestly, I've been using Optifine and dynamic lighting for as long as I've been playing the game and have never noticed any drops in performance. There's an almost 80% FPS drop with your mod. That is excessive and unacceptable.

Optifine and LambDynamicLights use different methods for creating dynamic lighting. Optifine uses a shader, while LDL rebuilds the chunk each time there's a movement. Chunk rebuilding is more expensive than a shader, but it's much easier to maintain.

This is false, OptiFine and LambDynamicLights are using the same method: chunk rebuilds. The only moment shader dynamic lighting is involved is when you actually involve a shader, that's all.

It's slow, yes. OptiFine either delays the chunk rebuild or optimizes something in the chunk rebuilding stack. All I know is I cannot modify the chunk rebuilding stack, it's entirely out of scope for the mod, and would cause incompatibilities.

I've done testing with a bunch of moving lights recently, and I could not notice any FPS drop, there is something wrong somewhere.

@simonjonnemeth If you are using Sodium, use Always Defer Chunk Updates: yes, it fixed some of the FPS issues for some.

So, now before anyone else complains about the mod being slow, post hardware info and mod list, so that I can have actual data and no more claims in the void. I can't just guess stuff if all I get is "it doesn't work".

LambdAurora avatar Dec 30 '21 09:12 LambdAurora

Honestly, I've been using Optifine and dynamic lighting for as long as I've been playing the game and have never noticed any drops in performance. There's an almost 80% FPS drop with your mod. That is excessive and unacceptable.

Optifine and LambDynamicLights use different methods for creating dynamic lighting. Optifine uses a shader, while LDL rebuilds the chunk each time there's a movement. Chunk rebuilding is more expensive than a shader, but it's much easier to maintain.

This is false, OptiFine and LambDynamicLights are using the same method: chunk rebuilds. The only moment shader dynamic lighting is involved is when you actually involve a shader, that's all.

It's slow, yes. OptiFine either delays the chunk rebuild or optimizes something in the chunk rebuilding stack. All I know is I cannot modify the chunk rebuilding stack, it's entirely out of scope for the mod, and would cause incompatibilities.

I've done testing with a bunch of moving lights recently, and I could not notice any FPS drop, there is something wrong somewhere.

@simonjonnemeth If you are using Sodium, use Always Defer Chunk Updates: yes, it fixed some of the FPS issues for some.

So, now before anyone else complains about the mod being slow, post hardware info and mod list, so that I can have actual data and no more claims in the void. I can't just guess stuff if all I get is "it doesn't work".

AMD Ryzen 9 5950X, Asus TUF RTX-3090 O24G

Minecraft 1.18.1

Mods:

Fabric API 0.44.0+1.18 FallingTree 2.16.1 Iris 1.1.3 Sodium 0.4.0-alpha5+build.9 Sodium Extra 0.3.7

simonjonnemeth avatar Dec 30 '21 16:12 simonjonnemeth

Same here

t0mtee avatar Jan 24 '22 17:01 t0mtee

Same here

Just so you know, I'm using Sildur's Enhanced Default shaders via Iris now, which, as of recently added support for handheld lighting which makes this mod obsolete for me. If you have the hardware for it, it runs perfectly well.

simonjonnemeth avatar Jan 24 '22 20:01 simonjonnemeth

Any "same here" response without any hardware details will be marked as off-topic now.

LambdAurora avatar Jan 24 '22 20:01 LambdAurora

I am getting microstuttering as well with all dynamic light sources. The microstuttering stops set to fastest or fast. I7-10700, Nvidia Geforce RTX 3070, 32GB/4gb allocated https://spark.lucko.me/RkJd3wRgve This is from a fresh gradle build from cloning this project.

Edit: Sorry, this appears to only be an issue for 1.17. I booted up an instance in GDLauncher for 1.18 and I am getting great performance now.

baileyholl avatar Feb 11 '22 03:02 baileyholl

@LambdAurora If you are using Sodium, use Always Defer Chunk Updates: yes, it fixed some of the FPS issues for some.

Sadly using ADCU has really bad side effects so even if it can be a temporary solution, it's not the final solution I'll make vid on my main pc when i come back home

Julienraptor01 avatar May 06 '22 09:05 Julienraptor01