AurorasDecorations icon indicating copy to clipboard operation
AurorasDecorations copied to clipboard

Recipe conflict with Consistency+

Open magneticflux- opened this issue 3 years ago • 5 comments

C+ adds stone to the stone_crafting_materials tag, which results in the recipe for "Sturdy Stone" replacing the vanilla recipe for stone bricks. I reported this here instead of to C+ since it seems like this was a misuse of the stone_crafting_materials tag to mean "cobblestone and blackstone" when those should probably be explicitly stated. I recommend using #c:cobblestone instead.

magneticflux- avatar Nov 08 '22 07:11 magneticflux-

stone_crafting_materials is used for crafting pickaxes or furnaces

Stone being added to it is weird imo

LambdAurora avatar Dec 10 '22 19:12 LambdAurora

Idk, not being able to craft a stone pickaxe with stone is also kinda weird lol

magneticflux- avatar Dec 10 '22 20:12 magneticflux-

My bad, the tag is used for the furnace and the brewing stand.

Them adding stone to the tag is a strange decision to me.

LambdAurora avatar Dec 10 '22 20:12 LambdAurora

It was added in this commit https://github.com/ConsistencyPlus/ConsistencyPlus/commit/d79da7b07a4e7e028c577b8b962802a62b7f8f41#diff-4a47d44272e73934e791429440f7b6c3937911cf2ba21cca43ca2208c991ab73, so we could just ask @Cart3r1234 for clarification.

magneticflux- avatar Dec 10 '22 20:12 magneticflux-

The intention was to allow crafting stone-based recipes (including tools; we do modify both tags) with any block type considered a stone (stone, andesite, diorite, granite, tuff, dripstone, calcite, deepslate, blackstone, and for some reason basalt) following Mojang allowing crafting stone items out of blackstone and deepslate, however we were unaware that this is what caused that recipe conflict.

At some point I would like to try and knock out as many C+/AD conflicts as possible, although I'm not too sure how we'd go about doing that. A lot of the same blocks are added by both of our mods, and there are quite a few identical recipes. Identical recipes involving vanilla blocks would be the real challenge.

Cart3r1234 avatar Dec 11 '22 00:12 Cart3r1234