Lalit

Results 56 comments of Lalit

@timabbott Bumping this PR for a quick review since it's been some time.

Updates: ![Screenshot 2023-06-28 145703](https://github.com/zulip/zulip/assets/84276404/37082a4d-d8a2-4bc9-9a7d-5d81ef109c39) - Added appropriate line breaks. - Added a sentence for clarifying who can deactivate an emoji. - Made changes to the sentences as suggested by @gnprice...

@heyiming It looks a little weird to me that the width of the tab switcher is greater than that of search bar, I think they should be of same width,...

It definitely looks better than before @heyiming đź‘Ť

@amanagr created another commit for the third change as per your review!

@timabbott I can't reproduce bugs with new commits it seems good to me!

@timvisee So I have been trying this but it looks like there isn’t any way to write a test similar to the one you gave as proof of concept at...

I agree that having tuples of URL and service handlers will make code a little bit complex. Yeah I was thinking of having a tuple of (URL, Handlers) so that...

Thanks for pointing that out @andersk but here we also need the `key` pressed data for other stuff which I think `input` event doesn't have?

Yeah splitting the handlers sounds like a better option. Since as you said `InputEvent.data` does not return keystrokes like "backspace" or "Arrow" keys.